🪟 🐛 Fix job failures not showing when discover schema fails while creating a connection #15624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmundito
added
type/bug
krishnaglick
approved these changes
Aug 16, 2022
… `LogsRequestError` when there are logs.
…g 0 when there are no attempts
edmundito
force-pushed
the
edmundito/fix-discover-schema-job-fail
branch
from
9e815b5 to
4964eac
Compare
rodireich
pushed a commit
that referenced
this pull request
Aug 25, 2022
…ating a connection (#15624) * Fix status check on `JobItem` and ensure that `SourceService` returns `LogsRequestError` when there are logs. * Remove `SynchronousJobReadWithStatus` interface, no longer needed. * Fix conditional check in JobItem/MainInfo to prevent it from rendering 0 when there are no attempts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #9056
Shows the failure log when discovering the schema fails while creating a new connection.
Additionally removes a "0" from showing up when there is only one failed job attempt.
Related to changes in #11524 and #12071
How
/discover_schemafails is a LogsRequestError, which is what the component checks to render the log.SynchronousJobReadWithStatusintroduced in Generated API Client #12071. When switching to the generated API some of the custom status injection was lost. Now the Job status is determined based on the.succeededproperty.Recommended reading order
airbyte-webapp/src/core/domain/connector/SourceService.tsairbyte-webapp/src/components/JobItem/JobItem.tsxTests
This area impacts logs both on the connection status page and on the connection create and replication view settings. Tested both!